You can't go by me I always want the latest... I would say unless you want different with iPhone X then probably another year won't be a bad thing with sticking with what's still a great phone..
I'm upgrading from 7 Plus to 8 Plus but I do that every year regardless so it depends on why you want to upgrade.
Like Bkdodger I like having the latest.